Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
go-mysql-server
Iter.Next(),RowToSQL, andcallbackinto separate threadsThis PR expands on an optimization where we separate
iter.Next()andRowToSQL+callback()into two separate threads. Now,iter.Next(),RowToSQL, andcallback()all run in their own goroutines with corresponding buffered channels communicating between them.Additionally, this PR tidys up the
resultForDefaultIterandresultForValueItercode.Benchmarks: threads bump dolthub/dolt#10103 (comment)
SQLandSQLValueThis PR adds unsafe string access to
EnumType.SQLValue()andSetType.SQLValue().Additionally, uses string concat over
SPrintf().Benchmarks: test unsafe bump dolthub/dolt#10101 (comment)
IsNullablereturn true for nullable datetime functionsfixes dolthub/dolt#10092
I updated the datetime functions'
IsNullablefunction based on whether they could return nil, usingfunction_queries.gofrom #3305 as a reference.We should probably do an audit of all our functions to make sure
IsNullableis correct.Closed Issues
Performance
| Overall Mean Multiple | 1.52 |
|:---------------------:|:----:|
View the full release notes at https://github.com/dolthub/dolt/releases/tag/v1.78.2.